pytest-dev/pytest-html

Add links to images in self contained report

Open

#110 opened on May 5, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (253 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (770 stars)
PR merge metrics
 (Avg merge 8h 28m) (9 merged PRs in 30d)

Description

When --self-contained-html is used we should provide links to any images in the HTML report. We should avoid duplicating the large data URI values, so it makes sense to use JavaScript to enable this functionality.

The links in the report column could be hidden by default and displayed via JavaScript, and the href destination could be taken from the associated img src. Similarly, the img could be an inactive link, enabled via JavaScript if enabled.

Contributor guide

Research direction
Examine the self contained HTML report generation code. Identify where images are included as data URIs. Add hidden links in the report column with href set to the data URI, and use JavaScript to make them visible. Ensure the img element itself becomes a clickable link when JavaScript is enabled.
Tech stack
pythonjavascripthtml
Domain
backendtestingdevtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonHTMLJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70