pyro-ppl/pyro

Add order parameter to spline_coupling helper function

Open

#3,417 opened on Jan 24, 2025

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (8,211 stars) (981 forks)batch import
help wantedusability

Description

The spline_coupling helper function currently lacks an order parameter, which would allow users to specify the spline's order (linear or quadratic). This is inconsistent with the SplineCoupling class, which already supports the order parameter.

Adding the order parameter to the spline_coupling helper function will improve flexibility for users.

Example of the modified spline_coupling function:

Image

Contributor guide

Tech stack
pythonpytorch
Domain
machine learningbackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonPyro basicsSpline coupling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Locate the spline coupling helper function in the Pyro codebase, likely in the transforms module. Review the SplineCoupling class to understand how the order parameter is implemented there. Then add the order parameter to the helper function, ensuring consistent behavior. The issue provides an example image of the expected modification.