pyro-ppl/pyro

Add order parameter to spline_coupling helper function

Open

#3,417 opened on Jan 24, 2025

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (981 forks)batch import
help wantedusability

Repository metrics

Stars
 (8,211 stars)
PR merge metrics
 (Avg merge 10d 19h) (1 merged PR in 30d)

Description

The spline_coupling helper function currently lacks an order parameter, which would allow users to specify the spline's order (linear or quadratic). This is inconsistent with the SplineCoupling class, which already supports the order parameter.

Adding the order parameter to the spline_coupling helper function will improve flexibility for users.

Example of the modified spline_coupling function:

Image

Contributor guide

Research direction
Locate the spline coupling helper function in the codebase, review the SplineCoupling class to understand how order is implemented, then add an order parameter to the helper function with similar logic.
Tech stack
pythonpytorch
Domain
machine learningai
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70