pyro-ppl/pyro

Feature request: Prohibit passing negative numbers to plate sizes

Open

#3,407 opened on Oct 24, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (8,211 stars) (981 forks)batch import
help wantedusability

Description

Issue Description

Plate primitives scale log-likelihood terms by size/batch_size. But plates allow negative numbers without a warning or assert. Something like assert size > 0 above https://github.com/pyro-ppl/pyro/blob/dev/pyro/primitives.py#L424 might be worth adding.

Contributor guide

Tech stack
pythonpytorch
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
Add an assertion `assert size > 0` in the file pyro/primitives.py around line 424, inside the plate function or related code. No further investigation needed; the change is straightforward.