pyro-ppl/pyro

Feature request: Prohibit passing negative numbers to plate sizes

Open

#3,407 opened on Oct 24, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (981 forks)batch import
help wantedusability

Repository metrics

Stars
 (8,211 stars)
PR merge metrics
 (Avg merge 10d 19h) (1 merged PR in 30d)

Description

Issue Description

Plate primitives scale log-likelihood terms by size/batch_size. But plates allow negative numbers without a warning or assert. Something like assert size > 0 above https://github.com/pyro-ppl/pyro/blob/dev/pyro/primitives.py#L424 might be worth adding.

Contributor guide

Research direction
Add an assertion `assert size > 0` in the plate function in pyro/primitives.py before line 424 to prevent negative plate sizes.
Tech stack
pythonpytorch
Domain
machine learningaibackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80