pyro-ppl/pyro

List: move these things upstream to PyTorch, Funsor, etc.

Open

#2,630 opened on Sep 16, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (981 forks)batch import
help wantedrefactor

Repository metrics

Stars
 (8,211 stars)
PR merge metrics
 (Avg merge 10d 19h) (1 merged PR in 30d)

Description

This issue tracks Pyro components that should be moved to upstream dependencies.

Move to PyTorch

  • constraints.IndependentConstraint
    • usage in MultivariateNormal
    • usage in dist.Independent
  • dist.Delta #1781
  • constraints.integer
  • Geometric.log_prob() as patched in pyro/distributions/torch.py
  • Uniform's ._unbroadcasted_* logic
  • _with_cache() in pyro/infer/reparam/unit_jacobian.py
  • dist.DirichletMultinomial https://github.com/pytorch/pytorch/issues/56030

Move to Funsor

See also https://github.com/pyro-ppl/funsor/issues/362

  • distributions.util.detach()
  • ops.tensor_utils.haar_transform() and .inverse_haar_transform()

Contributor guide

Research direction
Study the listed Pyro components and understand their dependencies on PyTorch and Funsor. For each item, identify the corresponding upstream API and ensure compatibility.
Tech stack
pythonpytorch
Domain
machine learningbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20