pyro-ppl/pyro

Enable warnings in tests/test_examples.py

Open

#2,201 opened on Dec 3, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (981 forks)batch import
help wantedwarnings & errors

Repository metrics

Stars
 (8,211 stars)
PR merge metrics
 (Avg merge 10d 19h) (1 merged PR in 30d)

Description

I just noticed that our usual pytest warnings filters (-Werror with a few exceptions) do not apply to the eamples/*.py when run by subprocess.check_call(), leading to some warnings raised by examples.

I tried sketching a possible solution in the example-warnings branch, but it appears difficult to specify exact warnings, and there are some possibly unrelated issues with torch_shm_manager and with the jit raising SystemError: ... returned a result with an error reset.

Contributor guide

Research direction
Investigate how to propagate pytest warning filters (e.g., Werror) to subprocess calls that run example scripts. Look at the existing warning filter setup in pytest configuration and adapt it for subprocess. Consider using environment variables like PYTHONWARNINGS or modifying the subprocess call to pass appropriate flags.
Tech stack
pythonpytorch
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60