pypi/warehouse

Update all IP Addresses in tests to use RFC-5735 TEST-NET-* addresses.

Open

#13,186 opened on Mar 10, 2023

View on GitHubContributor guide
 (3 comments) (1 reaction) (0 assignees)Python (1,201 forks)auto 404
good first issuetesting

Repository metrics

Stars
 (4,097 stars)
PR merge metrics
 (PR metrics pending)

Description

nitpick: ‏super nitpicky, and not the first violation of this type in the codebase, but per RFC-5735 we ought to use addresses in TEST-NET-* ranges. Thankfully we have pytest-socket (#humbebrag) to prevent actual network calls, so it's not an issue, but I wanted to note it while it was fresh in my head. (Also see https://www.rfc-editor.org/rfc/rfc6890#section-2.2.2) Might be worth a full sweep cleanup as a separate PR.

Originally posted by @miketheman in https://github.com/pypi/warehouse/pull/13164#discussion_r1131763629

Contributor guide

Research direction
Identify all IP addresses used in tests that are not in RFC 5735 TEST NET ranges, replace them with valid test addresses (e.g., 192.0.2.0/24, 198.51.100.0/24, 203.0.113.0/24), and verify tests pass.
Tech stack
python
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75