pypa/pipx

Need to include PYTHONPATH for non-HomeBrew and non-Flask use

Open

#911 opened on Nov 13, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (7,844 stars) (363 forks)batch import
enhancementhelp wanted

Description

How would this feature be useful?

PYTHONPATH has been removed to fix #233 and adjusted to fix #636. However, due to how pipx install functions (using the version of pip inside the new virtualenv it creates), I need to add to PYTHONPATH the path to the customized library that enables my authentication for a specialized PyPI mirror.

Describe the solution you'd like

Ideally, since the only platform that seems to have caused the issue leading to #233 is macOS with Homebrew, one might check for this instead of removing PYTHONPATH unconditionally. Alternatively, one could introduce another command-line option to either add back to PYTHONPATH (possibly via extra_python_paths).

Describe alternatives you've considered

The only workaround I've found so far is tweaking my installed version of pipx to prevent it from removing PYTHONPATH.

Contributor guide

Tech stack
python
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonpipxPYTHONPATHvirtual environments
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the changes made in #233 and #636 to understand why PYTHONPATH was removed. Examine the code around extra python paths in src/pipx/util.py (line 375). Consider implementing a conditional check for Homebrew or adding a command line option to allow PYTHONPATH preservation. Check the existing tests for environment handling.
Need to include PYTHONPATH for non-HomeBrew and non-Flask use · pypa/pipx#911 | Good First Issue