pymc-devs/pymc

Unify `distributions/transform.py` and `logprob/transform.py`

Open

#6,908 opened on Sep 13, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (7,926 stars) (1,902 forks)batch import
help wantedlogprobmaintenance

Description

Description

These modules and, more importantly, respective tests are quite redundant. This is due to part of the functionality being moved to aeppl and then back to pymc via the logprob submodule in the past.

We should probably get rid of distributions/transforms, and possibly split the latter in two files: one for ValueTransforms and RVTransform classes and subclasses, and the other for find_measurable_transform rewrites and related functionality, as that module is getting pretty large.

Contributor guide

Tech stack
python
Domain
developer experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python experienceUnderstanding of PyMCFamiliarity with codebase structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the contents of distributions/transform.py and logprob/transform.py to understand the overlap. Review the corresponding test files to identify redundancy. Plan to consolidate the modules, possibly splitting into two files: one for ValueTransforms and RVTransform classes, and another for find measurable transform rewrites.