pymc-devs/pymc

Fail tests with unexpected warnings

Open

#6408 opened on Dec 21, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (7,926 stars) (1,902 forks)batch import
beginner friendlyhelp wantedmaintenancetests

Description

Description

Some great maintenance work to cleanup warnings was done in #6067 and #6074 (probably more)

More recently, I started adding pytestmark = pytest.mark.filterwarnings("error"), as in #6407

Ideally, we would move to failing with warnings in the entire test suite, so that we don't regress and catch deprecation issues earlier on. The approach taken in #6407 might be a good start if there's too much going on.

https://docs.pytest.org/en/7.1.x/how-to/capture-warnings.html

Contributor guide

Tech stack
python
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
pytestPython warning filters
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Start by examining the approach taken in PR #6407, which added 'pytestmark = pytest.mark.filterwarnings("error")' to some tests. Then, consider applying the same marker globally in the test configuration, optionally using pytest's configuration files to treat all warnings as errors. Be prepared to fix any tests that currently trigger warnings, which may involve updating deprecated usage or adding expected warning filters.