pymc-devs/pymc

Fail tests with unexpected warnings

Open

#6,408 opened on Dec 21, 2022

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Python (1,902 forks)batch import
beginner friendlyhelp wantedmaintenancetests

Repository metrics

Stars
 (7,926 stars)
PR merge metrics
 (Avg merge 11d) (7 merged PRs in 30d)

Description

Description

Some great maintenance work to cleanup warnings was done in #6067 and #6074 (probably more)

More recently, I started adding pytestmark = pytest.mark.filterwarnings("error"), as in #6407

Ideally, we would move to failing with warnings in the entire test suite, so that we don't regress and catch deprecation issues earlier on. The approach taken in #6407 might be a good start if there's too much going on.

https://docs.pytest.org/en/7.1.x/how-to/capture-warnings.html

Contributor guide

Research direction
Identify test files that lack filterwarnings('error') mark and add pytestmark = pytest.mark.filterwarnings('error') to enforce warnings as errors, while ensuring no new failures are introduced.
Tech stack
python
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60