pymc-devs/pymc

Investigate failing test `test_parallel_sampling.py::test_abort`

Open

#4,954 opened on Aug 19, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (1,902 forks)batch import
help wantedtests

Repository metrics

Stars
 (7,926 stars)
PR merge metrics
 (Avg merge 11d) (7 merged PRs in 30d)

Description

This cropped up in #4952, where we marked it as skip (https://github.com/pymc-devs/pymc3/pull/4952/commits/6249cf5082e7adb9c62ac78debb1cc20b8de5d9d) because it passed in one of the runs but failed in the next one.

It fails locally for me as well.

Contributor guide

Research direction
Run the test multiple times with pytest repeat to confirm flakiness. Examine the test logic in test parallel sampling.py::test abort and the related skip commit. Investigate potential race conditions in parallel sampling abort mechanism by adding logging or using thread sanitizers.
Tech stack
python
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50