pymc-devs/pymc

Investigate failing test `test_parallel_sampling.py::test_abort`

Open

#4954 opened on Aug 19, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (7,926 stars) (1,902 forks)batch import
help wantedtests

Description

This cropped up in #4952, where we marked it as skip (https://github.com/pymc-devs/pymc3/pull/4952/commits/6249cf5082e7adb9c62ac78debb1cc20b8de5d9d) because it passed in one of the runs but failed in the next one.

It fails locally for me as well.

Contributor guide

Tech stack
python
Domain
machine learning
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Basic Python testing knowledgeFamiliarity with pytestUnderstanding of parallel execution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Start by examining the test file `test parallel sampling.py`, specifically the `test abort` function. Review the related PR #4952 and the skip commit (6249cf5) for context. Run the test locally with verbose output to capture the failure. Investigate potential race conditions in the parallel sampling code, looking at files like `pymc3/sampling.py` or `pymc3/parallel sampling.py`.