pylint-dev/pylint

Question: Is there a reason that `invalid-envvar-default` only checks `os.getenv`, not `os.environ.get`

Open

#10,092 opened on Nov 22, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Python (4,978 stars) (1,059 forks)batch import
False Negative 🦋Good first issueHacktoberfestHelp wanted 🙏Needs PR

Description

is there a reason that invalid-envvar-default only checks os.getenv, not os.environ.get?

https://github.com/pylint-dev/pylint/blob/68cb5b320653ad64c68ff48a4bb4ba449a01d3a6/pylint/checkers/stdlib.py#L33

Contributor guide

Tech stack
python
Domain
tooling
Issue type
research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonpylint checker APIos.environ usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the checker in pylint/checkers/stdlib.py around line 33 to understand the current implementation of invalid envvar default. Check if os.environ.get is intentionally excluded or if it's an oversight. Review any comments on this issue (issue #10092) for maintainer input. Consider adding support for os.environ.get by extending the function that checks envvar defaults.