pylint-dev/pylint

False negative ``superfluous-parens`` when around two conditional and an ``and``

Open

#10,084 opened on Nov 18, 2024

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Python (1,059 forks)batch import
False Negative 🦋Good first issueNeeds PR

Repository metrics

Stars
 (4,978 stars)
PR merge metrics
 (Avg merge 58d 21h) (63 merged PRs in 30d)

Description

Bug description

This code should raise C0325:

a = 1

if (1 == 1 and 2 == 1):
    pass

if (a is None and a is not None):
    pass

Command used

pylint --disable=all --enable=C0325 kk.py

Pylint output

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 0.00/10, +10.00)

Expected behavior

Raise C0325

Pylint version

pylint 3.3.1
astroid 3.3.5
Python 3.12.7 (tags/v3.12.7:0b05ead, Oct  1 2024, 03:06:41) [MSC v.1941 64 bit (AMD64)]

Contributor guide

Research direction
Inspect the superfluous parens checker in pylint, understand how it handles 'and' conditions with two conditionals, and add a test case with fix.
Tech stack
python
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40