[bug] Increasing workers size - missing variables during initialization

Open Beginner friendly
#1,032 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
python
Domain
distributed-systems, hpc

Research direction

Locate the BlockAllocationTaskScheduler implementation and compare its initial worker setup with the rescaling path triggered by self.max_workers. Trace how the listed worker parameters are constructed and passed in each path. Done means workers created during rescaling receive the same required initialization context and the existing scheduler behavior remains intact.

Written by the indexing model from the issue text.

Description

bug

In the BlockAllocationTaskScheduler the workers are initialized with the following additional parameters:

{
    "worker_id": worker_id,
    "stop_function": lambda: _interrupt_bootup_dict[self_id],
    "bootup_event": bootup_events[worker_id],
    "next_bootup_event": (
        bootup_events[worker_id + 1]
        if worker_id + 1 < self._max_workers
        else None
    ),
    "alive_workers": alive_workers,
    "alive_workers_lock": alive_workers_lock,
}

But these additional parameters are not provided when the workers are rescaled using self.max_workers.

Dominant language
Python
Stars
77
Forks
7
Avg merge
10h 32m
Merged PRs (30d)
12

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pyiron/executorlib

All issues in pyiron/executorlib

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.