Task decorator removes docstring

Open
#971 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Start in invoke/tasks.py around lines 353-358 and inspect how the @task decorator creates the Task object. Run the relevant existing tests for task decorators, then verify that a decorated function retains its docstring.

Written by the indexing model from the issue text.

Description

When using @task, the decorated function loses it's docstring, because internally a functools.wraps is missing here
https://github.com/pyinvoke/invoke/blob/edbb0b11b92452201c6516562140a20a2502a413/invoke/tasks.py#L353-L358

Easy to fix:

@wraps(body)
 def inner(body: Callable) -> Task[T]: 
     _task = klass(body, **kwargs) 
     return _task 
Dominant language
Python
Stars
4.8k
Forks
412
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pyinvoke/invoke

All issues in pyinvoke/invoke

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.