Looks like the timeout option does not work on all platform/python version combinaisons

Open
#851 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Start with the linked test_ping_localhost_timedout() in tests/test_security_scans_wrapper.py and compare its behavior across the reported Ubuntu 20.04 and Python 3.7/3.9 combinations with the passing versions. Review the linked scans_wrapper/process.py wrapper and establish why the zero-second timeout differs; done means the test consistently produces no output after the process is killed.

Written by the indexing model from the issue text.

Description

Needs investigation

Hello,

I'm opening this issue because I'm running into a weird issue that I can't reproduce on my local computer but does happen inside github runners on specific platform / python version combinaison.

Namely, ubuntu-20.04 with python 3.7 or 3.9. Note that my tests passes on python 3.8 and python 3.6 (wtf).

I've code this little module that wraps invoke: https://github.com/tristanlatr/security-scans-wrapper/blob/main/scans_wrapper/process.py

And you can see the failing test here test_ping_localhost_timedout(). The test only ensure that nothing got printed out because the process got killed after zero seconds.

Tell me what you think,

Here's a screenshot of test builds status

Capture d’écran, le 2022-03-29 à 11 37 03

Talk to you later

Dominant language
Python
Stars
4.8k
Forks
412
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pyinvoke/invoke

All issues in pyinvoke/invoke

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.