pydantic/logfire

`test_logfire_api` doesn't look at `logfire_api.__all__`

Open

#335 opened on Jul 24, 2024

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Python (244 forks)github user discovery
Logfire APIgood first issue

Repository metrics

Stars
 (4,282 stars)
PR merge metrics
 (Avg merge 7d 8h) (35 merged PRs in 30d)

Description

It just uses logfire.__all__ in both versions of test_runtime. logfire_api.__all__ doesn't actually exist at runtime when logfire isn't importable.

Contributor guide

Research direction
Find the test file and replace references to logfire. all with logfire api. all in the test runtime functions.
Tech stack
python
Domain
backendtesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80