Bump pyo3 to v0.29.2 in Cargo.lock for next v50.0.x

Open Beginner friendly
#15,543 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python, rust

Research direction

Start by comparing Cargo.toml line 33 with Cargo.lock lines 254-256 to see how the PyO3 dependency is currently pinned. Review the linked PyO3 regression and MSYS2 context, then check whether updating the lockfile introduces interdependencies. Done means the next v50.0.x release uses PyO3 0.29.2 in Cargo.lock and remains compatible with the stated environments.

Written by the indexing model from the issue text.

Description

Would it be possible to release v50.0.x with pyo3 updated to v0.29.2 in Cargo.lock?
Or are there some other interdependencies making it not possible?

"Fix PyO3 0.29 regression with failure to link under Cygwin / MSYS2." should unlock possibility of installing cryptography package in venv under MinGW-w64 environments like MSYS2 UCRT64, which unfortunately remains broken for quite some time (and different reasons as the time passed).

Context:

  • PyO3/pyo3#6185
  • msys2/MINGW-packages#28218 (starting from comment)

Side question, which may be completely silly, as I have basically no knowledge of Rust and its ecosystem (and am somewhat confused with this whole Rust-within-Python approach):

Why Cargo.lock has not been updated during v50.0.1 release preparation process considering Cargo.toml specifies 0.29 and not 0.29.0?

https://github.com/pyca/cryptography/blob/ffde75a2b594822c740a2e4748b56c00548302bf/Cargo.lock#L254-L256

https://github.com/pyca/cryptography/blob/ffde75a2b594822c740a2e4748b56c00548302bf/Cargo.toml#L33

Hopefully answer may potentially help prevent this kind of issues in the future.

Dominant language
Python
Stars
7.8k
Forks
1.8k
Avg merge
7h 40m
Merged PRs (30d)
160

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from pyca/cryptography

All issues in pyca/cryptography

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.