py-why/dowhy

effect_modifiers

Open

#767 opened on Nov 18, 2022

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Python (6,453 stars) (883 forks)batch import
buggood first issue

Description

Describe the bug I'm trying to estimate the causal effect by calling the "econml" package and specified an "effect_modifiers" variables that is continuous value ,but also I want set the parameters "num_quantiles_to_discretize_cont_cols = 6"

Steps to reproduce the behavior

dml_estimate = model.estimate_effect(identified_estimand, method_name="backdoor.econml.dml.DML",
                                     control_value = 0,
                                     treatment_value = 1000,
                                     effect_modifiers=['solar_radiation'],
                                 target_units = 'ate',#lambda df: df["diffusion_conditions"]==1,  # condition used for CATE
                                 confidence_intervals=False,
                                     num_quantiles_to_discretize_cont_cols = 6,
                                method_params={"init_params":{
                                                              'model_y':GradientBoostingRegressor(),
                                                              'model_t': GradientBoostingRegressor(),
                                                              "model_final": LassoCV(fit_intercept=False),
                                                              'featurizer':PolynomialFeatures(degree=1, include_bias=True)
                                                              },
                                                "fit_params":{
                                                    'inference':BootstrapInference(n_bootstrap_samples=100, n_jobs=-1),}
                                               })

TypeError Traceback (most recent call last) ~\AppData\Local\Temp\ipykernel_3380\140799330.py in 25 }, 26 "fit_params":{ ---> 27 'inference':BootstrapInference(n_bootstrap_samples=100, n_jobs=-1),} 28 }) 29 print(dml_estimate)

TypeError: estimate_effect() got an unexpected keyword argument 'num_quantiles_to_discretize_cont_cols'

Expected behavior I really expected i would have report behavior like below: image

Version information:

  • DoWhy version [e.g. 0.7]

Additional context Add any other context about the problem here.

Contributor guide

Tech stack
python
Domain
datamachine learning
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Pythonfamiliarity with DoWhy API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the `estimate effect` method signature in the DoWhy source code (likely in `dowhy/causal estimator.py`) to confirm that `num quantiles to discretize cont cols` is not a valid argument. Check if this parameter belongs to another method like `CausalModel` or should be passed via `method params`. Review the documentation and existing tests for correct usage. Consider opening a PR to either add support for this parameter in `estimate effect` or clarify the error message to guide users to the correct parameter placement.