Paramter as_sysadmin_accounts does not behave in the same way as sql_sysadmin_accounts
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
Research direction
Start at the sql_instance resource and inspect how as_sysadmin_accounts and sql_sysadmin_accounts are handled. Review the referenced commit for the existing parameter behavior, reproduce the setup.exe command-line output with an array of quoted strings, and confirm both parameters produce equivalent quoting.
Written by the indexing model from the issue text.
Description
Describe the Bug
When passing an array or strings to as_sysadmin_accounts the output escapes each string that has been wrapped with quotes.
Expected Behavior
It should work in the same way as sql_sysadmin_accounts. Not escaping quotes when creating the setup.exe command line.
Steps to Reproduce
Steps to reproduce the behavior:
Pass an array of strings into the as_sysadmin_accounts parameter of the sql_instance resource, run puppet
Additional Context
I think the following commit was only applied to the sql_sysadmin_accounts parameters https://github.com/puppetlabs/puppetlabs-sqlserver/commit/fd3e772c40447016b70aa5d44a2077a72868778b it should also be applied to as_sysadmin_accounts
- Dominant language
- Ruby
- Stars
- 5
- Forks
- 22
- Avg merge
- 19h 50m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from puppetlabs/puppetlabs-sqlserver
-
bugfix community
Difficulty 1/5 Under an hour Newbie friendliness 92/100
puppetlabs/puppetlabs-sqlserver#509 · 2 comments ·
-
community
Difficulty 5/5 Over a week Newbie friendliness 25/100
puppetlabs/puppetlabs-sqlserver#465 · 1 reaction ·
-
community
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
bugfix community
Difficulty 4/5 3-5 days Newbie friendliness 35/100
puppetlabs/puppetlabs-sqlserver#427 · 4 comments · 2 reactions ·
All issues in puppetlabs/puppetlabs-sqlserver
Similar issues
-
user-reported
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Kong/developer.konghq.com#7316 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
TheOdinProject/curriculum#31408 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
notch8/utk_knapsack#148 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Homebrew/homebrew-cask#288729 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100