publiclab/mapknitter

Location Search does not work after error occurs

Open

#478 opened on Apr 2, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Ruby (203 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (274 stars)
PR merge metrics
 (PR metrics pending)

Description

What happened just before the problem occurred

If a user enter bad location coordinates or default values like 0.0 and 0.0 then it sets url to (--24) and location search does not work.

location

Relevant URLs

when you login something from your publiclab account https://mapknitter.org/maps/new https://mapknitter.org/maps

PublicLab.org username

igniteeng000 (to help reproduce the issue)

Browser, version, and operating system

Chrome, Windows 10

For bug reports, fill out the above template; for feature requests, you can delete the template.

Contributor guide

Research direction
Trace the code path from input of coordinates to URL generation, focusing on validation and error handling. Look for where default values like 0.0, 0.0 are processed and how invalid URLs like ' 24' are produced.
Tech stack
ruby
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70