videojs/video.js

EventedMixin.off or Player.removeTechControlsListeners_ function has some logic error

Open

#4.627 aberto em 21 de set. de 2017

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (7.502 forks)batch import
confirmedhelp wanted

Métricas do repositório

Stars
 (39.742 stars)
Métricas de merge de PR
 (Mesclagem média 111d 10h) (3 fundiu PRs em 30d)

Description

Description

EventedMixin.off function has some logic error, you can see the detail in steps to reproduce

Steps to reproduce

1.Player: this.tech_ is undefined when this highlight statement run image

2.EventedMixin.off : if targetOrType undefined and typeOrListener is eventType, I think the parameters adaptation logic is not handled in the right way image

3.Events.of pass the wrong parameters image

Results

Expected

remove the specified event type and listener

Actual

remove all player listener

Error output

no error output

Additional Information

<link href="../../../dist/video-js.css" rel="stylesheet">
<script src="../../../dist/ie8/videojs-ie8.js"></script>
<script src="../../../dist/video.js"></script>

<video id="player1" class="video-js vjs-default-skin" controls preload="auto" height="320" playsinline webkit-playinline>
</video>
<script>
    var player = videojs('player1',{
      sources: [{
        src: '//www.streambox.fr/playlists/x36xhzz/x36xhzz.m3u8',
        type: 'application/x-mpegURL'
      }]
    });
   player.on('ready', function() {
      console.log('player on ready');
    });
    player.on('error', function() {
      console.log('player on error');
    });
</script>

if error event triggered, the player ready listener will no fire, because player all event listener had been remove I know I did not use the contrib-hls. I modify EventedMixin.off function like that: image or modify Player removeTechControlsListeners_ image

versions

videojs

6.2.8

browsers

Chrome

OSes

windows 7 Mac OS X

plugins

no

Guia do colaborador