velero-io/velero

Make printer column titles consistent across all types

Aberta

#2.989 aberto em 6 de out. de 2020

 (2 comentários) (0 reação) (1 responsável)Go (1.550 forks)auto 404
Area/CLIGood first issueReviewed Q2 2021

Métricas do repositório

Stars
 (10.111 estrelas)
Métricas de merge de PR
 (Mesclagem média 5d 1h) (144 fundiu PRs em 30d)

Description

That does, however, put us in an awkward spot since I think all other .status.startTimestamp fields should match, due to the existence of the creationTimestamp field. Ideally, we'd have clean mappings between the field name in the YAML and printer column, but I think due to historical reasons we're a little stuck.

I think we could put that on the docket for v2.0 to update those velero commands so we don't break any scripts.

Originally posted by @nrb in https://github.com/vmware-tanzu/velero/pull/2881#discussion_r496236736

In adding the additional printer columns for CRDs, it was noted that the columns for the get commands were named inconsistently from the fields being displayed, but also that they were inconsistent across types. For example, .status.startTimestamp is displayed under the column CREATED when running velero get backups but is displayed under the column STARTED when running velero get restores.

We should revisit each of these types and determine how they should be printed and ensure they are all consistent with each other.

Guia do colaborador