unit8co/darts
Ver no GitHubImprove numerical stability of the NLL computation for some distributions
Open
#621 aberto em 1 de dez. de 2021
good first issueimprovement
Métricas do repositório
- Stars
- (6.832 stars)
- Métricas de merge de PR
- (Mesclagem média 143d 16h) (16 fundiu PRs em 30d)
Description
Not all Likelihoods have numerically-stable computaiton of the NLL. By default, we rely on the log_prob() function of the PyTorch Distribution objects, but it might not be the best way to get numerically stable gradients. I think it’s fairly easy to build cases where Negative Binomial fails for instance.
See: #663
Also for the Weibull distribution, the outputs changed when we changed the shape of the network outputs, which is weird and ideally should be investigated. Not clear if that’s due to numerical instability…