taichi-dev/taichi

[GGUI] Fix crash when certain keys are pressed.

Open

#3.254 aberto em 22 de out. de 2021

Ver no GitHub
 (3 comments) (2 reactions) (0 assignees)C++ (2.384 forks)batch import
good first issueguipotential bug

Métricas do repositório

Stars
 (28.195 stars)
Métricas de merge de PR
 (Nenhuma PRs mesclada em 30d)

Description

GGUI crashes when certain keys are pressed (The Windows key, for example).

Relevant code:

https://github.com/taichi-dev/taichi/blob/master/taichi/ui/common/input_handler.h https://github.com/taichi-dev/taichi/blob/master/taichi/ui/utils/utils.h

It would be great to support all of these keys, or at least add a try-catch to avoid the window from crashing.

Guia do colaborador