swiftlang/swift
Ver no GitHub[SR-8811] Diagnosing Implicit Accessors for Uninhabited Types Should Be Smarter
Open
#51.319 aberto em 20 de set. de 2018
SILcompilerdiagnostics qualitygood first issueimprovement
Métricas do repositório
- Stars
- (69.989 stars)
- Métricas de merge de PR
- (Mesclagem média 8d 17h) (510 fundiu PRs em 30d)
Description
| Previous ID | SR-8811 |
| Radar | None |
| Original Reporter | @CodaFi |
| Type | Improvement |
| Status | Reopened |
| Resolution |
| Votes | 0 |
| Component/s | Compiler |
| Labels | Improvement, SILDiagnostics, StarterBug |
| Assignee | None |
| Priority | Medium |
md5: fe8546f9296464e8c547c7c953e07a35
Issue Description:
Try to emit SIL for the following code
enum Empty {}
class Foo {
var x: Empty // function with uninhabited return type 'Empty' is missing call to another never-returning function on all paths
init(_ x: Empty) {
self.x = x
}
}
It's good that we error, it's dismaying that we're diagnosing an implicit declaration. In particular, we're diagnosing the getter. We should check for accessors and emit something specialized here.