stereobooster/react-snap

Disable Service Workers

Open

#314 aberto em 9 de dez. de 2018

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (4.982 stars) (403 forks)batch import
enhancementhelp wanted

Description

Feature Request

Is your feature request related to a problem? Please describe. More people recently mentioned that there are issue with serviceWorkers. I guess Chromium changed behaviour of serviceWorkers recently. As far as I remember they only worked over https, but now they work over http for localhost.

Describe the solution you'd like Do the same as minimalcss https://github.com/peterbe/minimalcss/issues/223

Describe alternatives you've considered none

Teachability, Documentation, Adoption, Migration Strategy should be minor version change

Guia do colaborador

Pilha de tecnologia
javascriptreactnodejs
Domain
frontendtooling
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-2 days
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
mostly clear
Prerequisites
Familiarity with service workersUnderstanding of react snap configurationBasic JavaScriptGit/PR workflow
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
35
Direção de pesquisa
Review the referenced minimalcss issue (#223) for implementation pattern. Investigate react snap's current service worker generation logic (likely in the build output step). Propose a new configuration option (e.g., 'disableServiceWorker') that skips the service worker file generation. Discuss with maintainers on the desired API and documentation.