Why are cookies excluded from /-/debug/headers? · sourcegraph/sourcegraph-public-snapshot

(2 comentários) (0 reação) (0 responsável)Go (1.374 forks)auto 404

good first issuesecuritysite-admin

Métricas do repositório

Stars: (10.290 estrelas)
Métricas de merge de PR: (Métricas PR pendentes)

Description

Question description

Question in title. Since SG uses some cookies for authentication and the like, it would be helpful to be able to see them in the headers debug page

Is your question related to a problem? If so, please describe or link to another issue.

Our organization has our own internal routing/proxy service in front of internal services like sourcegraph. In making sure everything is working as expected, I have been using the headers tab. If cookies impact the service, then it makes sense to me to include that info here.

Additional context

Tried looking in git blame to see if theres a reason for the below line , but it seems to have been here since open sourcing the code

https://github.com/sourcegraph/sourcegraph/blame/f86a5b342852697275bec5b5c94d02c86e9e007f/cmd/frontend/internal/app/app.go#L85

Guia do colaborador

Direção de pesquisa: Observe a linha referenciada em cmd/frontend/internal/app/app.go e examine o código ao redor para entender por que os cookies são excluídos da resposta / /debug/headers. Investigue se há um motivo de segurança ou privacidade e verifique se a exclusão foi intencional desde o início do código open source.
Pilha de tecnologia: go
Domain: backend
Tipo Issue: Pesquisa
Difficulty: 1
Tempo estimado: Menos de 1 hora
Status da atividade: Ativo
Clarity: Claro
Prerequisites: Go
Simpatia para novatos: 70