sindresorhus/execa

Attach `.nodeChildProcess` to the execa promise

Open

#413 aberto em 16 de fev. de 2020

Ver no GitHub
 (13 comments) (1 reaction) (0 assignees)JavaScript (6.091 stars) (219 forks)batch import
enhancementhelp wanted

Description

Node.js does this now for childProcess. when you promisify it.

https://nodejs.org/api/child_process.html#child_process_child_process_exec_command_options_callback

The name is to be decided.

One day, I hope we can get rid of execa() being both a childProcess and promise and just have the .child property on the promise. But that's a huge breaking change. For now, the best we can do is to add it, and recommend new users to use it instead of the old way. We could even un-document the old way.

@ehmicky Thoughts?

Guia do colaborador

Pilha de tecnologia
javascriptnodejs
Domain
backend
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-2 days
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
mostly clear
Prerequisites
Understanding of execa's promise APIFamiliarity with Node.js child process
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
50
Direção de pesquisa
The issue proposes adding a `.nodeChildProcess` property to the execa promise, similar to Node.js child process. Key discussion points include naming and the gradual deprecation of the old dual behavior. Examine execa's source code in index.js and main.js to understand the current promise implementation. Review Node.js documentation for `child process.exec` callback. Consider the maintainer's comments (especially @ehmicky) for design decisions. The goal is to add the property without breaking changes, potentially marking the old approach as deprecated. Further reading: linked issue discussion and any related PRs.