sindresorhus/element-ready

Use types directly from querySelector, without copying them

Open

#32 aberto em 29 de dez. de 2020

Ver no GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (447 stars) (17 forks)user submission
enhancementhelp wanted

Description

If the selector is 'a', querySelector‘s return type is be HTMLAnchorElement. To achieve the same in element-ready, we had to manually copy its types and adapt them to elementReady

Ideally, instead, we should try to “inherit” directly from the global querySelector so that, if its types are enhanced (via typed-query-selector or natively), element-ready automatically gets upgraded.

Note: We can't use Parameters<typeof querySelector> and such because it doesn't support overloads nor generics.

This has been unsuccessfully tried in #31. More info about it in that PR. A possible solution might be https://github.com/microsoft/TypeScript/issues/33185#issuecomment-526969274

Guia do colaborador

Pilha de tecnologia
typescriptjavascript
Domain
developer experience
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
mostly clear
Prerequisites
TypeScript genericsUnderstanding of querySelector types
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
50
Direção de pesquisa
Review the previous attempt in PR #31 to understand why it failed. Explore the suggested solution from the TypeScript issue comment (microsoft/TypeScript#33185). Investigate if 'typed query selector' can be integrated or if native TypeScript improvements (issue #29037) can be leveraged. Look at the current type definitions in the element ready package to see how types are copied and how they could be inherited from global querySelector.