serverless/serverless

Cannot set multiple key-value for an alb event "query" with the same key

Open

#11.880 aberto em 1 de abr. de 2023

Ver no GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (46.915 stars) (5.734 forks)batch import
cat/aws-event-albenhancementgood first issuehelp wanted

Description

Are you certain it's a bug?

  • Yes, it looks like a bug

Is the issue caused by a plugin?

  • It is not a plugin issue

Are you using the latest v3 release?

  • Yes, I'm using the latest v3 release

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Issue description

AWS Application Load Balancer listener rule allows to set multiple values for a single query key.

Currently this is not possible with Serverless Framework as query "value" is defined as string.

Service configuration (serverless.yml) content

service: sls-project

frameworkVersion: "3"

package:
  individually: true

provider:
  name: aws
  runtime: nodejs18.x
  versionFunctions: false
  region: eu-west-3
  vpc:
    subnetIds: [subnet-0e2db7f9558f501d7, subnet-0cde9f3600cab039a]
    securityGroupIds: [sg-029d2fbba38db2dc7]

functions:
  lambda:
    handler: src/handlers/lambda.default
    events:
      - alb:
          listenerArn: arn:aws:elasticloadbalancing:xxxx
          priority: 936
          conditions:
            path: "/users"
            method: [GET]
            query:
              role: admin
              role: guest

Command name and used flags

"N/A

Command output

"N/A

Environment information

Framework Core: 3.29.0 (local)
Plugin: 6.2.3
SDK: 4.3.2

Guia do colaborador

Pilha de tecnologia
javascriptnodejsaws
Domain
backendcloudapi
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
mostly clear
Prerequisites
Familiarity with Serverless FrameworkBasic knowledge of AWS ALBUnderstanding of JSON schema validation
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
40
Direção de pesquisa
The issue is that the `query` parameter in the `alb` event configuration only accepts a string value, but AWS Application Load Balancer allows multiple values for the same query key. To fix this, locate the schema definition for ALB events in the Serverless Framework codebase, likely in `lib/plugins/aws/package/compile/events/alb/index.js` or a related schema file. The fix would involve allowing the query value to be either a string or an array of strings. Additionally, check the existing tests for ALB event compilation to ensure the change is properly tested. There are no linked PRs or assignees, so this issue is available for contribution.