rust-lang/rust-clippy
Ver no GitHubManual Duration::{as_nanos,as_milis,as_secs_f64,as_secs_f32} implementation
Open
#6.068 aberto em 20 de set. de 2020
C-enhancementgood first issue
Métricas do repositório
- Stars
- (10.406 stars)
- Métricas de merge de PR
- (Mesclagem média 16d 6h) (79 fundiu PRs em 30d)
Description
What it does
Recognize cases of manual re-implementation of the builtin as_nanos and as_secs_f64 and as_secs_f32 functions on Duration.
Categories
- Kind: complexity, sometimes also correctness
Drawbacks
MSRV issues, implementing the suggestion might increase the MSRV.
Example
let nanos = diff.as_secs() * 1_000_000_000 + diff.subsec_nanos() as u64;
let milis = diff.as_secs() * 1_000 + diff.subsec_milis() as u64;
let secs_f64 = (diff.as_secs() as f64 * 1_000.0 + diff.subsec_milis() as f64) / 1000.0;
let secs_f64 = diff.as_secs() as f64 + diff.subsec_milis() as f64 / 1_000.0;
let secs_f64 = diff.as_secs() as f64 + diff.subsec_nanos() as f64 / 1_000_000_000.0;
Could be written as:
let nanos = diff.as_nanos() as u64;
let milis = diff.as_millis() as u64;
let secs_f64 = diff.as_secs_f64();
let secs_f64 = diff.as_secs_f64();
let secs_f64 = diff.as_secs_f64();