rust-lang/rust-clippy
Ver no GitHubif_same_then_else Should not warn for `else if` blocks.
Open
#3.770 aberto em 16 de fev. de 2019
I-false-positiveS-needs-discussiongood first issue
Métricas do repositório
- Stars
- (10.406 stars)
- Métricas de merge de PR
- (Mesclagem média 19d 22h) (113 fundiu PRs em 30d)
Description
if condition1() {
1
} else if condition2() {
1
} else if condition3() {
2
} else {
3
}
There are many cases where code like this shouldn't be warned on. While you could do condition1() || condition2() often times it is more clear of the intent if they are separate. Especially if the conditions are non-trivial compared to the value being returned.
I think the right time for this warning to warn is if the last if has the same condition as the else. For example the following two cases would warn.
if condition1() {
1
} else {
1
}
if condition1() {
1
} else if condition2() {
2
} else {
2
}