rust-lang/rust-clippy
Ver no GitHub`needless_range_loop` suggestion removes panics
Open
#16.003 aberto em 1 de nov. de 2025
C-bugI-suggestion-causes-buggood first issue
Métricas do repositório
- Stars
- (10.406 stars)
- Métricas de merge de PR
- (Mesclagem média 16d 6h) (79 fundiu PRs em 30d)
Description
Description
needless_range_loop currently suggests using take(n) when the iteration is not bounded by the vec's length. This is dangerous since it will silently truncate the iterated range which can very easily lead to data corruption. It may be fine to do so, but we don't have the necessary information to make that decision from clippy.
The following:
fn f() {
let n = 15;
let v = vec![1, 2];
for i in 0..n {
let _ = n;
let _ = v[i];
}
}
The current suggestion is effectively:
fn f() {
let n = 15;
let v = vec![1, 2];
for (i, x) in v.iter().enumerate().take(n) {
let _ = n;
let _ = *x;
}
}
It should be something that preserves the panic. e.g.:
fn f() {
let n = 15;
let v = vec![1, 2];
for (i, x) in v[..n].iter().enumerate() {
let _ = n;
let _ = *x;
}
}
Note that this will move the panic to occur before iteration rather than on the iteration that goes out of bounds. This behaviour is likely to be fine, but it should be called out by the lint when making this suggestion.
Version
clippy 0.1.91 (f8297e351a 2025-10-28)
Additional Labels
No response