rjsf-team/react-jsonschema-form

Recurring indexed titles in array items for themes other than core

Fechada

#4.011 aberto em 23 de dez. de 2023

Ver no GitHubGuia do colaborador
 (2 comentários) (0 reação) (1 responsável)TypeScript (2.136 forks)batch import
bughelp wanted

Métricas do repositório

Stars
 (13.175 estrelas)
Métricas de merge de PR
 (Mesclagem média 3d 17h) (32 fundiu PRs em 30d)

Description

Prerequisites

What theme are you using?

mui

Version

5.15.1

Current Behavior

The indexed titles which are handed down from the array property to its children are recurring for non core themes. For example, in this playground, the title/label array-1 is being used at two places.

Expected Behavior

The indexed titles should not repeat, similar to how the core theme works.

Steps To Reproduce

  1. Head to the playground example
  2. Notice that array-1 title/label is being repeated for both the first and second index

Environment

- Chrome: 120.0.6099.71

Anything else?

This is happening after a recent https://github.com/rjsf-team/react-jsonschema-form/pull/4002 PR. The indexed titles were taken care of for the core theme and are required for other themes as well.

Guia do colaborador

Direção de pesquisa
The issue is about recurring indexed titles in array items for non core themes (e.g., MUI). PR #4002 fixed this for the core theme. The fix likely involves how titles are generated or passed to array items. To resolve, examine the changes in PR #4002 and identify where non core themes diverge. Look at the theme components' rendering of array items, especially how they handle the `title` prop and indexed labels. The playground links in the issue provide concrete examples to test. Check the theme files under `packages/theme *` for the relevant rendering logic.
Pilha de tecnologia
typescriptreact
Domain
frontend
Tipo Issue
Bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 horas
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
Ativo
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
Claro
Prerequisites
Understanding of ReactBasic knowledge of JSON SchemaFamiliarity with PR #4002
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
45