rjsf-team/react-jsonschema-form

5.3.0: Array items perform much worse

Aberta

#3.517 aberto em 17 de mar. de 2023

 (22 comentários) (1 reação) (0 responsável)TypeScript (2.136 forks)batch import
arraysbughelp wantedperformance

Métricas do repositório

Stars
 (13.175 estrelas)
Métricas de merge de PR
 (Mesclagem média 3d 17h) (32 fundiu PRs em 30d)

Description

Prerequisites

What theme are you using?

core

Version

5.0.0-beta.18 vs. 5.0.0-beta.19

Current Behavior

We wanted to test out the latest update to rjsf (upgrading from 5.0.0 beta11 to 5.3.0) in order to benefit from the new ability to 'copy' array items, which was added as a feature in the latest release.

Unfortunately, the performance of the updated version is much worse when it comes to adding/removing array items - to an extent where it now takes ~1-2 seconds to add a new entry, up from <0.1 seconds in the previous release. After isolating the release introducing this, it seems to start after 5.0.0-beta.18.

I am unable to replicate this in the live playground, though I am unsure why.

Expected Behavior

I would expect the performance to be similar to previous versions.

Steps To Reproduce

  1. Use a standard rjsf setup with 5.0.0-beta.18 vs. 5.0.0-beta.19

  2. Use below custom array template:

  3. To replicate this, test with the below formdata (config) and schema/uischema. The slow performance can be seen by going to CAN CH1 and adding entries in the Transmit list section. json-schema.zip

Guia do colaborador