replicatedhq/ship

Long TF plans do not cause a scrollbar to appear in chrome

Aberta

#946 aberto em 21 de mai. de 2019

 (0 comentário) (1 reação) (0 responsável)Go (68 forks)auto 404
UIgood first issuetype::bug

Métricas do repositório

Stars
 (635 estrelas)
Métricas de merge de PR
 (Métricas PR pendentes)

Description

Expected behavior

When running the terraform step, all plan contents should be visible or there should be a scroll bar.

Actual behavior

A scrollbar never appears, and content clips off the bottom of the screen. If the page zoom is changed, content reflows and a scroll bar appears.

Information

  • Ship version: 0.43.1
  • Command line run: ship init ./ship.yaml
  • Chrome version: 74.0.3729.157 (Official Build) (64-bit) on OS X

The ship.yaml in question:

assets:
  v1:
    - terraform:
        dest: ./terraform/files.tf
        inline: |
          resource "local_file" "foo" {
            content     = "{{repl ConfigOption "id_length" }}"
            filename = "/tmp/foo.bar"
          }
          resource "local_file" "http-tf-check" {
            content     = "${data.http.tf-check.body}"
            filename = "./http.check"
          }
          resource "local_file" "http-example-com-check" {
            content     = "${data.http.example-com.body}"
            filename = "./example.com.check"
          }
          resource "local_file" "random_id" {
            content     = "${random_string.id.result}"
            filename = "./random_id.check"
          }
    - terraform:
        dest: ./terraform/http.tf
        inline: |
          provider "http" {}
          data "http" "tf-check" {
            url = "https://checkpoint-api.hashicorp.com/v1/check/terraform"
            request_headers {
              "Accept" = "application/json"
            }
          }
          data "http" "example-com" {
            url = "https://example.com"
            request_headers {
              "Accept" = "application/json"
            }
          }
    - terraform:
        dest: ./terraform/random.tf
        inline: |
          provider "random" {}
          resource "random_string" "id" {
            length = "{{repl ConfigOption "id_length" }}"
            special = true
            override_special = "/@\" "
          }

config:
  v1:
    - name: id
      items:
         - name: id_length
           title: ID Length
           type: text
           required: true
           default: 80
           help_text: bigger numbers make longer ids

lifecycle:
  v1:
    - message:
        contents: "hi"
    - render: {}
    - terraform:
        path: terraform/
    - message:
        contents: "bye"

Steps to reproduce the behavior

  1. Run ship with terraform contents that produce a long plan
  2. Observe the lack of scroll before changing zoom
  3. Change zoom and observe that scrolling is now possible

Guia do colaborador