recloudstream/cloudstream

Improve delayed updater triggering method

Aberta

#1.282 aberto em 16 de ago. de 2024

 (2 comentários) (1 reação) (0 responsável)Kotlin (877 forks)batch import
enhancementgood first issue

Métricas do repositório

Stars
 (9.642 estrelas)
Métricas de merge de PR
 (Mesclagem média 8d 8h) (63 fundiu PRs em 30d)

Description

Describe your suggested feature

Currently actually updating is done in onPause() in MainActivity, this causes inconsistent and unexpected triggering behavior. I suggest we move this to onDestroy() And add a persistent notification that says something like "Update now" on mobile, and auto stop app when you click update on TV. This is because onPause() is also triggered when you enter PiP mode or switch activities such as going to "Manage Accounts". I understand the reason for waiting is for user choice but the current implementation I don't think actually indicates "user choice" as if you forget about it or something and go home you inadvertently start the update which force stops the app. To me, this is bad behaviour.

Other details

No response

Acknowledgements

  • My suggestion is NOT about adding a new provider
  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.

Guia do colaborador