react-toolbox/react-toolbox

RadioGroup & RadioButton docs say `value` can be `Any`, but prop types validation expects `string`

Aberta

#1.580 aberto em 7 de jul. de 2017

 (5 comentários) (0 reação) (0 responsável)JavaScript (1.036 forks)batch import
Type: Enhancementgood first issue

Métricas do repositório

Stars
 (8.676 estrelas)
Métricas de merge de PR
 (Nenhuma PRs mesclada em 30d)

Description

The docs state that the value prop supplied to a <RadioGroup> and <RadioButton> may be of any type, but the prop types validation expects a string for both (here and here).

Supplying any value does appear to work, although it triggers a prop type warning and doesn't technically result in valid DOM markup since the actual input value in the DOM will get coerced to a string, resulting in [object Object] for all the radio buttons that receive an object as the value.

Guia do colaborador