pytorch/ignite

`Timer`'s misleading behaviour when epoch completion time calculated

Open

#2.157 aberto em 11 de ago. de 2021

Ver no GitHub
 (7 comments) (1 reaction) (1 assignee)Python (4.313 stars) (602 forks)batch import
HacktoberfestPyDataGlobalenhancementhelp wanted

Description

When I tried calculating the time taken to complete a single epoch via Timer, the handlers attached to trainer before Timer were executed first, and thus their time also got recorded by the Timer too for a single epoch. Therefore the true time taken for epoch completion, provided by trainer.state.times, is less than what Timer calculated. This can be misleading. More clarification on how this actually works in the docs would be appreciated. Or the Timer's functionality can be enhanced to step before all other handlers attached to an event could also be helpful. Notebook to quickly verify this here.

Guia do colaborador

Pilha de tecnologia
pythonpytorch
Domain
machine learningdeveloper experience
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
2
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
Familiarity with PyTorch Ignite event system
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
70
Direção de pesquisa
Examine the Timer implementation in PyTorch Ignite, specifically how it hooks into events. The issue suggests that Timer should step before other handlers. Check the source code for the Timer class and its event registration. Consider whether a simple reordering of handler execution or a new event attribute is needed. The provided Colab notebook can be used to reproduce the issue.