pymc-devs/pymc

CheckParameterValues not replaced in inner graphs

Open

#6.697 aberto em 28 de abr. de 2023

Ver no GitHub
 (3 comments) (0 reactions) (0 assignees)Python (1.902 forks)batch import
help wantedlogprob

Métricas do repositório

Stars
 (7.926 stars)
Métricas de merge de PR
 (Mesclagem média 11d 6h) (12 fundiu PRs em 30d)

Description

We include these rewrites when compiling logp graphs, but this won't replace inner logp graphs (e.g, inside Scan or not-inlined OpFromGraph)

https://github.com/pymc-devs/pymc/blob/371472dcf1c44f99a9ad4e7317606404b2a47a0e/pymc/pytensorf.py#L1142-L1144

The example in #6696 suffers from this. Sampling is quite faster when the rewrite is manually added

Guia do colaborador