project-chip/connectedhomeip

Remove redundancy from CI execution bulrbs for python tests

Open

#38.665 aberto em 29 de abr. de 2025

Ver no GitHub
 (0 comments) (0 reactions) (1 assignee)C++ (1.659 forks)batch import
CI/CD improvementsgood first issue

Métricas do repositório

Stars
 (6.410 stars)
Métricas de merge de PR
 (Mesclagem média 8d 5h) (375 fundiu PRs em 30d)

Description

CI test arguments are generally documented at https://project-chip.github.io/connectedhomeip-doc/testing/python.html#defining-the-ci-test-arguments

When looking through examples like https://github.com/project-chip/connectedhomeip/blob/master/src/python_testing/TC_CC_2_2.py#L23 , a lot of arguments are repeated throughout all tests. As test generally are copied & pasted, it makes the reviewr not focus on "what changes are relevant" and instead the app-specific parts are contained within the "noise" of other parameters (like discriminator, passcode, trace-to, kvs, commissioning-method, storage path are all the same almost always).

We should allow having only "important CI parts" in the test argument blurb and everything else could be a default (e.g. we already have a yaml file with all paths, we can add defaults in there).

There was some work started in #37494 however PR author in the mean time left the project. We need an updated implementation and have progress on this.

We can do this in steps:

  • support common arguments (including removal of defaults somehow
  • integrate this into the default environment
  • update all python tests to remove redundant bits

Guia do colaborador