prettier/prettier

Passing in an ignored file should emit a warning

Open

#15.700 aberto em 21 de nov. de 2023

Ver no GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (51.868 stars) (4.716 forks)batch import
area:clihelp wanted

Description

Environments:

  • Prettier Version: 3.1.0
  • Running Prettier via: CLI
  • Runtime: All
  • Operating System: All
  • Prettier plugins (if any):

Steps to reproduce:

StackBlitz: https://stackblitz.com/edit/stackblitz-starters-gw5hhu?file=package.json

  1. Run npm run node_modules to demonstrate that prettier does not warn that the file in node_modules is ignored. It actually doesn't understand the file path.

[error] No matching files. Patterns: ./node_modules/vue/dist/vue.global.prod.js

  1. Run npm run dist to demonstrate that prettier will ignore the file in the .gitignored directory, but still output the original code without warning that an ignored file was passed in

Expected behavior:

For prettier to inform the user that the code was not prettified because the file path matched the ignore list

It should also warn if the path is in node_modules, that the user should set --with-node-modules.

Actual behavior: No warnings

Guia do colaborador

Pilha de tecnologia
javascriptnodejs
Domain
clideveloper experience
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
2
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
half day
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
fresh
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
familiarity with Prettier CLINode.js basicsunderstanding of ignore patterns
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
70
Direção de pesquisa
Investigate how Prettier processes file arguments and applies ignore patterns. Look at the CLI entry point (likely src/cli/index.js) to understand where file matching occurs. Consider adding a warning when a file matches an ignore pattern, similar to how other errors are emitted. Also handle node modules case as mentioned in the issue.