pinojs/pino

bindings() and setBindings() are not present in the browser version of pino

Open

#1.177 aberto em 20 de out. de 2021

Ver no GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (13.157 stars) (839 forks)batch import
enhancementgood first issue

Description

Hello!

I was attempting to use pino in the browser today and discovered that .bindings() is undefined. Additionally, .setBindings() is also undefined, but it's also undocumented in general (is it officially part of the API?).

I looked into adding this to browser.js but I'd definitely need some guidance before proceeding. For example, I'm not sure if bindings changes cascade through child loggers or if they are fixed at the time of child creation, for example.

Guia do colaborador

Pilha de tecnologia
javascript
Domain
backendfrontend
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
2
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-3 hours
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
needs maintainer response
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
familiarity with pino's APIknowledge of child logger behavior
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
60
Direção de pesquisa
Start by examining the browser.js file in the repository to understand how the browser logger is implemented. Check the documentation for bindings() and setBindings() in the Node.js version. Look at how child loggers are created and if bindings are mutable. The issue author requested guidance, so it would be helpful to review any comments for additional context.