oppia/oppia

[Feature Request]: Remove E2E test collections.js and learnerFlow.js

Open

#24.491 aberto em 14 de jan. de 2026

Ver no GitHub
 (16 comments) (0 reactions) (1 assignee)Python (5.292 stars) (3.534 forks)batch import
Impact: HighWork: Mediumenhancementgood first issue

Description

Is your feature request related to a problem? Please describe.

We are currently migrating from E2E tests to Acceptance tests, however, some of the E2E tests are still not covered by Acceptance tests. So, we need to write acceptance tests covering uncovered E2E tests and delete the corresponding E2E test.

Acceptance test "CC.1. Create a collection" is created to cover the features currently covered by E2E test "collections".

Acceptance test "LO.13. View a collection" is created to cover the features currently covered by E2E test "learnerFlow".

Describe the solution (or solutions) you'd like

Write the new acceptance (CC.1. Create a collection) test and delete the existing E2E test (collections).

Steps to follow:

  1. Create a new acceptance tests for collection creator and logged out learner. (test-suite file should be named "create-a-collection.spec.ts").
  2. Write the acceptance test based on "CC.1. Create a collection" from E2E Migration Doc. And WIP Sheet (External Users)
  3. Add acceptance test to acceptance.json (https://github.com/oppia/oppia/blob/develop/core/tests/ci-test-suite-configs/acceptance.json).
  4. Run newly created test-suite locally and ensure it passes.
  5. Push the code to your repo-fork.
  6. Stress test the new test-suite to check for flakes. (In your Oppia repo fork, go to Actions > Stress Test Acceptance Test > Run Workflow > branch: <YOUR_FEATURE_BRANCH_NAME>, runs: <ATLEAST_20>, test-suite: <TEST_SUITE_NAME_USED_IN_ACCEPTANCE.JSON>.
  7. Ensure that all jobs passes in the above workflow run.
  8. Remove E2E test, collections.js and learnerFlow.js.
  9. Open a PR :)

Other References: puppeteer-acceptance-tests is the base folder for acceptance tests. Acceptance tests: https://github.com/oppia/oppia/wiki/Acceptance-Tests

Describe alternatives you've considered and rejected

No response

Additional context

No response

Guia do colaborador

Pilha de tecnologia
javascripttypescriptnodejs
Domain
testingfull stack
Tipo Issue
feature
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
1-2 days
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
active
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
clear
Prerequisites
JavaScriptAcceptance testingGitCI/CD workflows
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
60
Direção de pesquisa
This issue involves replacing existing E2E tests with acceptance tests. Start by reviewing the provided E2E Migration Doc and WIP Sheet for test scenario details. Create a new acceptance test suite file named 'create a collection.spec.ts' in the 'core/tests/puppeteer acceptance tests' directory. Add the suite to 'core/tests/ci test suite configs/acceptance.json'. Run the test locally to ensure it passes, then stress test by running the workflow in your fork's Actions with at least 20 runs. Finally, remove the old E2E files 'collections.js' and 'learnerFlow.js' before opening a PR.