openzfs/zfs

Ability to specify type to 'zfs destroy`

Open

#9.522 aberto em 28 de out. de 2019

Ver no GitHub
 (7 comments) (15 reactions) (0 assignees)C (1.703 forks)batch import
Type: Featuregood first issue

Métricas do repositório

Stars
 (9.908 stars)
Métricas de merge de PR
 (Mesclagem média 5d 21h) (62 fundiu PRs em 30d)

Description

System information

Type Version/Name
Distribution Name all
Distribution Version all
Linux Kernel all
Architecture all
ZFS Version all
SPL Version all

Describe the problem you're observing

There are no safeguards when destroying. Whatever is the argument of zfs destroy, it will get destroyed. Issuers of the destroy command are humans and humans can make mistakes: for example in shell scripts that generate destroy commands, typos etc.

A minimal protection mechanism could reject a destroy action if the type of the dataset to be destroyed does not match the dataset type specified in command line, similar to how zfs list -t works, so for example zfs destroy -t filesystem pool/volumename or zfs destroy -t snapshot pool/filesystem would fail.

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs

Guia do colaborador