opensearch-project/OpenSearch

Docker is required to build

Open

#1.406 aberto em 21 de out. de 2021

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)Java (1.505 forks)batch import
bughelp wanted

Métricas do repositório

Stars
 (8.123 stars)
Métricas de merge de PR
 (Mesclagem média 5d 9h) (266 fundiu PRs em 30d)

Description

Is your feature request related to a problem? Please describe.

Coming from https://github.com/opensearch-project/OpenSearch/issues/1379, docker is required to build. But there seems to be code in place trying to say "if you don't have docker, that's ok, I'll just skip those parts". That doesn't work.

Describe the solution you'd like

Skip distribution:docker* if docker is not available.

Additional context

Docker (checked [/usr/bin/docker, /usr/local/bin/docker, C:\Program Files\Docker\Docker\resources\bin\docker.exe]) is required to run the following tasks:
:distribution:docker:buildArm64DockerImage
:distribution:docker:buildDockerImage
you can address this by attending to the reported issue, or removing the offending tasks from being executed.

To reproduce, return null from DockerSupportServices.java, private Optional<String> getDockerPath() or run on Windows.

Current workaround:

$ ./gradlew build -x ":distribution:docker:buildArm64DockerImage" -x ":distribution:docker:buildDockerImage"

Guia do colaborador