open-telemetry/opentelemetry-dotnet
Improve instrument name validation and log messages
Aberta
#2.532 aberto em 27 de out. de 2021
enhancementhelp wantedkeep-openmetrics
Métricas do repositório
- Stars
- (3.725 estrelas)
- Métricas de merge de PR
- (Mesclagem média 3d 17h) (112 fundiu PRs em 30d)
Description
In PR #2470 we added validation for instrument and view names according to the spec. This issue is to track a small follow up that came up from PR comments :
- Use guard helpers: https://github.com/open-telemetry/opentelemetry-dotnet/pull/2470#discussion_r737044427
- Improve the message, specifying what was the original invalid name (instrument or view) https://github.com/open-telemetry/opentelemetry-dotnet/pull/2470#discussion_r737045347