ninja-build/ninja

Signal handling does not work as expected

Open

#1.241 aberto em 16 de fev. de 2017

Ver no GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (1.544 forks)batch import
help wanted

Métricas do repositório

Stars
 (10.194 stars)
Métricas de merge de PR
 (Mesclagem média 39d 3h) (10 fundiu PRs em 30d)

Description

Ninja on POSIX systems currently puts children in their own process group. This policy causes a variety of problems, since ninja doesn't perfectly forward signals to children --- for example, C-z in the terminal sends a SIGTSTP (and then SIGSTOP) to ninja, but since ninja doesn't do anything special for SIGTSTP, the compilation jobs keep running. SIGINT frequently doesn't interrupt compilation jobs either.

In GNU Make, all of these interactions work as you'd expect.

Why do we need to put subprocesses in their own process group? This whole issue disappears if we don't put children in their own process groups, let them inherit the controlling terminal, and allow signal propagation to work normally.

Guia do colaborador