microsoft/perfview

Freeze processing in EventPipeEventSource if uncaught exception is thrown in callback.

Open

#1.290 aberto em 15 de out. de 2020

Ver no GitHub
 (0 comments) (0 reactions) (0 assignees)C# (3.819 stars) (687 forks)batch import
bughelp wanted

Description

Environment

  • Microsoft.Diagnostics.Tracing.TraceEvent: 2.0.61
  • Microsoft.Diagnostics.NETCore.Client: 0.2.141901
  • EventPipe sender app and receiver app's TFM: net5.0-rc2

Steps to reproduce

  1. run app which produce EventSource event periodically
  2. start EventPipe session by DiagnosticClient
  3. create EventPipeEventSource from event stream
  4. set callback to DynamicEventParser.All
    • Exception will be thrown in callback
  5. start processing

full test code is uploaded to gist

Expected result

callback is invoked periodicaly, or at least terminate event processing when EventPipeEventSource.StopProcessing is called.

Actual result

callback was never invoked again, and EventPipeEventSource.Process never returned, even if EventPipeEventSource.StopProcessing was called.

Guia do colaborador

Pilha de tecnologia
csharp
Domain
observabilityperformance
Tipo Issue
bug
DifficultyDificuldade de implementação estimada para um novo contribuidor, de 1 para alterações muito pequenas a 5 para trabalho de nível especializado.
3
Tempo estimadoUm intervalo de tempo aproximado para um colaborador experiente investigar, implementar, testar e preparar um pull request.
half day
Status da atividadeQuão disponível o issue aparece agora: novo, ativo, obsoleto, bloqueado ou aguardando entrada do mantenedor.
stale
ClarityCom que clareza o issue explica a mudança esperada, os critérios de aceitação e a próxima etapa.
needs investigation
Prerequisites
C#.NETEventPipe
Simpatia para novatosUma pontuação de 1 a 100 que estima o quão acessível este issue é para colaboradores iniciantes.
20
Direção de pesquisa
Investigate the EventPipeEventSource class in the Microsoft.Diagnostics.Tracing.TraceEvent library to understand how callbacks are invoked and how exceptions are handled. The issue shows that an uncaught exception in the callback causes the event loop to freeze. Look for try catch blocks around callback invocations and ensure exceptions are caught to avoid freezing. Also check the StopProcessing mechanism to ensure it can interrupt a frozen loop.