mgechev/revive

Opposite of increment-decrement (for non-loop-counter usage)

Aberta

#910 aberto em 29 de set. de 2023

 (1 comentário) (0 reação) (0 responsável)Go (316 forks)github user discovery
good first issuerule proposal

Métricas do repositório

Stars
 (5.517 estrelas)
Métricas de merge de PR
 (Mesclagem média 10h 48m) (3 fundiu PRs em 30d)

Description

Is your feature request related to a problem? Please describe.

The increment-decrement rule is quite opinionated, as many rules are. However, its suggestion is problematic in the sense that e.g.

  • it's not that common of a practice in my experience to use ++/-- in contexts other than loop counters in Go code, e.g. stdlib
  • many programming languages don't even have those operators (for example Python, Rust, Swift, Zig)

Describe the solution you'd like

increment-decrement can be disabled like all others, no problem with that, and that does not require a solution.

But for the above reasons, a rule that would do the opposite of increment-decrement for anything but loop counters would be nice to have.

Describe alternatives you've considered

Just disabling increment-decrement, but that won't help with adoption of the += 1 style.

Additional context

N/A.

Guia do colaborador